Use static imports for Assertions.assertThat() consistently#48630
Closed
izeye wants to merge 1 commit intospring-projects:mainfrom
Closed
Use static imports for Assertions.assertThat() consistently#48630izeye wants to merge 1 commit intospring-projects:mainfrom
izeye wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: Johnny Lim <izeye@naver.com>
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
reviewed
Dec 28, 2025
Member
snicoll
left a comment
snicoll
left a comment
There was a problem hiding this comment.
Thanks for the PR. We are not using the static import in assert implementations (main code). I think we should keep it this way. WDYT?
Contributor
Author
|
@snicoll Thanks for the feedback! I don't have a strong opinion on it. I just thought that it's prefered based on the following changes: 90faddf#diff-e9d603edb2e72b3fc962233b6ae08d6391b61bb776bc86ce2039df7860f05866R233 |
Member
|
Good point, I remember reviewing this and then going with it as the OP is an AssertJ maintainer but I think we may want to reconsider this. I'll flag for team attention to get more feedback. |
snicoll
added
for: team-attention
This comment was marked as resolved.
This comment was marked as resolved.
Pankraz76
pushed a commit
to Pankraz76/spring-boot
that referenced
this pull request
Dec 29, 2025
Signed-off-by: Vincent Potucek <vpotucek@me.com>
Pankraz76
pushed a commit
to Pankraz76/spring-boot
that referenced
this pull request
Jan 4, 2026
Signed-off-by: Vincent Potucek <vpotucek@me.com>
```
Changes have been made to build-plugin/spring-boot-maven-plugin/src/main/java/org/springframework/boot/maven/ClassPath.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/io/InspectedContent.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/build/Cache.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/build/BuildpackReference.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/docker/configuration/DockerConfigurationMetadataTests.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/docker/configuration/ResolvedDockerHostTests.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/EphemeralBuilderTests.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$InstantAtOffsetRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/BuildRequestTests.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/ImageBuildpackTests.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to cli/spring-boot-cli/src/test/resources/commands/command.groovy by:
org.openrewrite.java.format.RemoveTrailingWhitespace
Changes have been made to cli/spring-boot-cli/src/test/resources/dir-sample/code/app.groovy by:
org.openrewrite.java.format.RemoveTrailingWhitespace
Changes have been made to cli/spring-boot-cli/src/test/resources/scripts/closure.groovy by:
org.openrewrite.java.format.RemoveTrailingWhitespace
Changes have been made to cli/spring-boot-cli/src/test/resources/scripts/command.groovy by:
org.openrewrite.java.format.RemoveTrailingWhitespace
Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/info/SslInfoTests.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/logging/AbstractLoggingSystemTests.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/convert/PeriodToStringConverterTests.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ZeroPeriodRecipe
Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/convert/PeriodStyleTests.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ZeroPeriodRecipe
Changes have been made to core/spring-boot-test/src/main/java/org/springframework/boot/test/util/TestPropertyValues.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to core/spring-boot-test/src/main/java/org/springframework/boot/test/system/OutputCapture.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityLambdaRecipe
Changes have been made to loader/spring-boot-loader/src/main/java/org/springframework/boot/loader/net/protocol/nested/NestedUrlConnection.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to loader/spring-boot-loader-tools/src/main/java/org/springframework/boot/loader/tools/SizeCalculatingEntryWriter.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/web/exchanges/HttpExchange.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ClockInstantRecipe
Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/management/HeapDumpWebEndpoint.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/info/InfoPropertiesInfoContributor.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/invoker/cache/CachingOperationInvoker.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/filewatch/ChangedFile.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/restart/MainMethodTests.java by:
org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReference
Changes have been made to module/spring-boot-jetty/src/main/java/org/springframework/boot/jetty/autoconfigure/JettyWebServerFactoryCustomizer.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-jetty/src/test/java/org/springframework/boot/jetty/autoconfigure/JettyWebServerFactoryCustomizerTests.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to module/spring-boot-kafka/src/main/java/org/springframework/boot/kafka/autoconfigure/ConcurrentKafkaListenerContainerFactoryConfigurer.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-micrometer-metrics/src/main/java/org/springframework/boot/micrometer/metrics/autoconfigure/ssl/SslMeterBinder.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ClockInstantRecipe
Changes have been made to module/spring-boot-micrometer-metrics/src/test/java/org/springframework/boot/micrometer/metrics/autoconfigure/ssl/SslMeterBinderTests.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to module/spring-boot-security/src/test/java/org/springframework/boot/security/autoconfigure/UserDetailsServiceAutoConfigurationTests.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityLambdaRecipe
Changes have been made to module/spring-boot-sql/src/main/java/org/springframework/boot/sql/autoconfigure/init/OnDatabaseInitializationCondition.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$NegationRecipe
Changes have been made to module/spring-boot-tomcat/src/test/java/org/springframework/boot/tomcat/servlet/TomcatServletWebServerFactoryTests.java by:
org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReference
Changes have been made to module/spring-boot-webflux/src/test/java/org/springframework/boot/webflux/observation/autoconfigure/WebFluxObservationAutoConfigurationTests.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$DurationOfSecondsRecipe
Changes have been made to module/spring-boot-zipkin/src/main/java/org/springframework/boot/zipkin/autoconfigure/ZipkinHttpClientSender.java by:
org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReference
Changes have been made to test-support/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/classpath/resources/Resources.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to test-support/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/system/OutputCapture.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityLambdaRecipe
Please review and commit the results.
Estimate time saved: 3h 6m
BUILD SUCCESSFUL in 18m 9s
```
Pankraz76
pushed a commit
to Pankraz76/spring-boot
that referenced
this pull request
Jan 4, 2026
Signed-off-by: Vincent Potucek <vpotucek@me.com>
```
Changes have been made to build-plugin/spring-boot-maven-plugin/src/main/java/org/springframework/boot/maven/ClassPath.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/io/InspectedContent.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/build/Cache.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/build/BuildpackReference.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/docker/configuration/DockerConfigurationMetadataTests.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/docker/configuration/ResolvedDockerHostTests.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/EphemeralBuilderTests.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$InstantAtOffsetRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/BuildRequestTests.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/ImageBuildpackTests.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to cli/spring-boot-cli/src/test/resources/commands/command.groovy by:
org.openrewrite.java.format.RemoveTrailingWhitespace
Changes have been made to cli/spring-boot-cli/src/test/resources/dir-sample/code/app.groovy by:
org.openrewrite.java.format.RemoveTrailingWhitespace
Changes have been made to cli/spring-boot-cli/src/test/resources/scripts/closure.groovy by:
org.openrewrite.java.format.RemoveTrailingWhitespace
Changes have been made to cli/spring-boot-cli/src/test/resources/scripts/command.groovy by:
org.openrewrite.java.format.RemoveTrailingWhitespace
Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/info/SslInfoTests.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/logging/AbstractLoggingSystemTests.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/convert/PeriodToStringConverterTests.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ZeroPeriodRecipe
Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/convert/PeriodStyleTests.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ZeroPeriodRecipe
Changes have been made to core/spring-boot-test/src/main/java/org/springframework/boot/test/util/TestPropertyValues.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to core/spring-boot-test/src/main/java/org/springframework/boot/test/system/OutputCapture.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityLambdaRecipe
Changes have been made to loader/spring-boot-loader/src/main/java/org/springframework/boot/loader/net/protocol/nested/NestedUrlConnection.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to loader/spring-boot-loader-tools/src/main/java/org/springframework/boot/loader/tools/SizeCalculatingEntryWriter.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/web/exchanges/HttpExchange.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ClockInstantRecipe
Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/management/HeapDumpWebEndpoint.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/info/InfoPropertiesInfoContributor.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/invoker/cache/CachingOperationInvoker.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/filewatch/ChangedFile.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/restart/MainMethodTests.java by:
org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReference
Changes have been made to module/spring-boot-jetty/src/main/java/org/springframework/boot/jetty/autoconfigure/JettyWebServerFactoryCustomizer.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-jetty/src/test/java/org/springframework/boot/jetty/autoconfigure/JettyWebServerFactoryCustomizerTests.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to module/spring-boot-kafka/src/main/java/org/springframework/boot/kafka/autoconfigure/ConcurrentKafkaListenerContainerFactoryConfigurer.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-micrometer-metrics/src/main/java/org/springframework/boot/micrometer/metrics/autoconfigure/ssl/SslMeterBinder.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ClockInstantRecipe
Changes have been made to module/spring-boot-micrometer-metrics/src/test/java/org/springframework/boot/micrometer/metrics/autoconfigure/ssl/SslMeterBinderTests.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to module/spring-boot-security/src/test/java/org/springframework/boot/security/autoconfigure/UserDetailsServiceAutoConfigurationTests.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityLambdaRecipe
Changes have been made to module/spring-boot-sql/src/main/java/org/springframework/boot/sql/autoconfigure/init/OnDatabaseInitializationCondition.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$NegationRecipe
Changes have been made to module/spring-boot-tomcat/src/test/java/org/springframework/boot/tomcat/servlet/TomcatServletWebServerFactoryTests.java by:
org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReference
Changes have been made to module/spring-boot-webflux/src/test/java/org/springframework/boot/webflux/observation/autoconfigure/WebFluxObservationAutoConfigurationTests.java by:
tech.picnic.errorprone.refasterrules.TimeRulesRecipes
tech.picnic.errorprone.refasterrules.TimeRulesRecipes$DurationOfSecondsRecipe
Changes have been made to module/spring-boot-zipkin/src/main/java/org/springframework/boot/zipkin/autoconfigure/ZipkinHttpClientSender.java by:
org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReference
Changes have been made to test-support/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/classpath/resources/Resources.java by:
tech.picnic.errorprone.refasterrules.FileRulesRecipes
tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to test-support/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/system/OutputCapture.java by:
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityLambdaRecipe
Please review and commit the results.
Estimate time saved: 3h 6m
BUILD SUCCESSFUL in 18m 9s
```
Closed
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
I don't feel particularly strongly about it, but I lean towards consistently using the static import in both main and test code. |
Pankraz76
pushed a commit
to Pankraz76/spring-boot
that referenced
this pull request
Jan 5, 2026
Signed-off-by: Vincent Potucek <vpotucek@me.com>
Pankraz76
pushed a commit
to Pankraz76/spring-boot
that referenced
this pull request
Jan 5, 2026
Signed-off-by: Vincent Potucek <vpotucek@me.com>
Member
|
I don't have a strong opinion in either direction. |
Member
|
Cool, thanks both. Let's go with the consistent option to use the static import then. |
snicoll
removed
the
for: team-attention
snicoll
pushed a commit
that referenced
this pull request
Jan 6, 2026
See gh-48630 Signed-off-by: Johnny Lim <izeye@naver.com>
snicoll
added a commit
that referenced
this pull request
Jan 6, 2026
Does this mean the rule? It reads like so because consistency can only be achieved via some gatekeeper, which is currently not the case, as discovered in: |
philwebb
added a commit
that referenced
this pull request
Jan 6, 2026
Add a rule to ensure we consistently use `assertThat` rather than `Assertions.assertThat`. See gh-48630
Member
|
@Pankraz76 Good idea, I've added a rule in 92263e7 |
philwebb
added a commit
that referenced
this pull request
Jan 6, 2026
|
ah nice thx, yes check also capable of doing, so we having all parties happy. Got some gate keeper and no new tool. well done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes to use static imports for
Assertions.assertThat()consistently where possible.